Disable list of commands from playground repositories #897 - Commands Blacklisted #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucifercr07
requested changes
Oct 6, 2024
There was a problem hiding this comment.
@yashbudhia thanks for contributing, please add tests for this.
pkg/util/blacklist.go
Outdated
| "strings" | ||
| ) | ||
|
|
||
| var blacklistedCommands = []string{ |
There was a problem hiding this comment.
Shall we keep it as map bool, so that checks would be faster?
There was a problem hiding this comment.
Yes, that would be faster, let me apply the changes
pkg/util/blacklist.go
Outdated
| } | ||
|
|
||
| // IsBlacklistedCommand checks if a command is blacklisted | ||
| func IsBlacklistedCommand(cmd string) error { |
There was a problem hiding this comment.
Please rename this to BlockListedCommand
|
ok |
|
@yashbudhia please resolve conflicts once. |
I have resolved the conflicts and changed the name of the function to BlockListedCommand |
lucifercr07
requested changes
Oct 6, 2024
i have fixed the build and also removed the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the issue Disable list of commands from playground repositories #897 in the main dice repository , this PR adds a
Tests -
Manually tested via postman for get as well as post routes and all blacklisted commands are throwing
errors in this fashion{"error": "ERR unknown command '{Command_name}"}
eg-
Scope for improvement
You can also test scenarios like: